sta_config_equal #5937
Merged
sta_config_equal #5937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure. Maybe by adding a comment in |
|
Thanks @dontsovcmc I did not notice these updates, good catch, and yes this has been an issue in the past also when this struct changes. I do like the struct integrity checking using a size constraint assert. |
|
I forgot to mention #5939 (keeping track of reasons) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug with reconnect to the same WiFi after running Active Point.
Long description: tzapu/WiFiManager#782
sta_config_equal(conf_compare, conf) doesn't compare all fields.
https://github.com./esp8266/Arduino/blob/master/libraries/ESP8266WiFi/src/ESP8266WiFiSTA.cpp#L160
This is a reason of failed connection for me. Maybe you can test it for another cases.